search

Automattic / vip-jetpack

Jetpack changes for VIP Go (DEPRECATED and moved to https://github.com/Automattic/vip-go-mu-plugins/tree/master/vip-jetpack)
GNU General Public License v2.0
2 stars 1 forks source link

Fix issue with photon image URLs being return incorrectly by our filter #13

Closed scottsweb closed 8 years ago

scottsweb commented 8 years ago

For consideration of @simonwheatley

scottsweb commented 8 years ago

Pinging @nickdaugherty to give this an :eyes: when you get in. It works in our testing and has been deployed but would love your input.

bazza commented 8 years ago

Did you test this with other sites' Photon URLs embedded in post_content? Like https://i2.wp.com/ma.tt/files/2013/02/DSC01277.jpg

scottsweb commented 8 years ago

@bazza excellent point! We will need to have another shot at this I think, will do some testing now.

scottsweb commented 8 years ago

Looks like we are OK. Demo page with two hotlinked Photon images (plus a few others) is here: http://eggloo.uk/sample-page/

Only the first image (red leaves) is impacted by this code (and is the only one in the media library of the local site). My guess is there are checks in Jetpack for ignoring existing Photon URLs already.