search

Automattic / wc-calypso-bridge

20 stars 4 forks source link

Error in \A8C\FSE #1455

Closed rrennick closed 7 months ago

rrennick commented 7 months ago

Prerequisites

Describe the bug

Originally reported in https://github.com/woocommerce/woocommerce/issues/45242 by someone testing WooExpress. Initial investigation tracked this down to

Apologies if I've missed a bit of context, but the screenshot suggests the origin of this problem is outside of WooCommerce (ie, it's in the Full Site Editing plugin):

https://plugins.trac.wordpress.org/browser/full-site-editing/tags/4.15083/help-center/class-help-center.php#L106

wp_localize_script(
    'help-center-script',
    'helpCenterLocale',
    \A8C\FSE\Common\get_iso_639_locale( determine_locale() )
);

Looks like A8C\FSE\Common\get_iso_639_locale() returns a string, but wp_localize_script() expects an array. Perhaps we should close and/or alert that other project?

I'll close the original issue with a reference to this one

Expected behavior

No debug warning

Actual behavior

Debug warning

Steps to reproduce

1- Use a WooExpress test site 2- Install query monitor 3- Go to any page at "Backend". 4- Observe that "Doing it Wrong" error is displayed on Query Monitor.

WordPress Environment

Default WooExpress test site

Isolating the problem

PanosSynetos commented 7 months ago

Hey @rrennick - Yes, please do tag that other project - Last time I had issues with the help-center, I had to ping someone from Calypso - See https://github.com/Automattic/wp-calypso/pull/84774 - See Slack too p1701439650581999/1697133351.273199-slack-C03N25JPCE4

Let's leave this open until it gets fixed

PanosSynetos commented 7 months ago

Pasting images here, I cannot open them bigger in original issue

image

image

image

PanosSynetos commented 7 months ago

Fixed by

rrennick commented 7 months ago

Yes, please do tag that other project

@PanosSynetos This is the repo we were given to transfer issues to from testing WooExpress. I'm not sure why GS originally reported it in the WC repo. I'm hoping this is a one off and GS has updated instructions. I would not expect any WooExpress customers to be reporting issues in the WC Github repo.