The https://github.com/Automattic/wc-calypso-bridge/pull/1449 created a side effect so that there are duplicate My Home menu on the Woo Express site with the classic interface. Before that patch, the jetpack_admin_menu_class returned the Ecommerce_Atomic_Admin_Menu, and then the My Home menu that pointed to the Calypso wasn't added. However, after that patch, the filter returned the Admin_Menu from Jetpack and it registered the My Home menu here. As it's the side effect from that PR, I think it would be better to remove the menu by Woo Express.
In the future, we can discuss whether to avoid the Admin_Menu from Jetpack registering the My Home menu since the menu doesn't seem to be necessary on the classic view.
Make sure there is only a single My Home menu that points to /wp-admin/admin.php?page=wc-admin
Other information:
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?
FOR PR REVIEWER ONLY:
[ ] I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.
Changes proposed in this Pull Request:
Closes https://github.com/Automattic/wp-calypso/issues/89398.
The https://github.com/Automattic/wc-calypso-bridge/pull/1449 created a side effect so that there are duplicate
My Home
menu on the Woo Express site with the classic interface. Before that patch, thejetpack_admin_menu_class
returned theEcommerce_Atomic_Admin_Menu
, and then theMy Home
menu that pointed to the Calypso wasn't added. However, after that patch, the filter returned theAdmin_Menu
from Jetpack and it registered theMy Home
menu here. As it's the side effect from that PR, I think it would be better to remove the menu by Woo Express.In the future, we can discuss whether to avoid the
Admin_Menu
from Jetpack registering theMy Home
menu since the menu doesn't seem to be necessary on the classic view.How to test the changes in this Pull Request:
My Home
menu that points to /wp-admin/admin.php?page=wc-adminOther information:
FOR PR REVIEWER ONLY: