Replace WCS&T tax onboarding with Woo Tax onboarding.

kloon commented 6 months ago

Changes proposed in this Pull Request:

Replace the WCS&T Tax onboarding with just Woo Tax.

Remove the jetpack requirement from the tax onboarding and update wording in step.
Added functionality to the addons screen override to handle installing Woo Tax and Woo Shipping for when we start supporting it via the addons screen.
Added functionality to suppress any future Woo Shipping and Woo Tax messaging that will get added to WC core.

These changes form part of the work to roll out the new Woo Shipping and Woo Tax to WooExpress sites.

[ ] This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

Testing instructions taken from #975

Test Woo Tax

Click on "Yes please" and observe that you're redirected to Homescreen with Tax task completed Go to WooCommerce > Settings > Tax Observe that you have Enable automated taxes selected in the Automated taxes dropdown Go to WooCommerce > Home > Tax task Click on No thanks, I'll set up manually and observe that you're redirected to tax settings screen Go to WooCommerce > Home > Tax task Click on I don't charge sales tax Observe that you're redirected to Homescreen with Tax task completed

Test manual configuration

Go to WooCommerce > Settings > General Remove all address fields, set store country to "Malaysia - Johor" and save Go to WooCommerce > Home > Tax task Fill in all store address fields in Set store location and click on continue Click on Configure and observe that you're redirected to tax settings Go to WooCommerce > Settings > General Observe that the store address values are saved from the values inserted in the previous form

[ ] Have you followed the Writing high-quality testing instructions guide?

Other information:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?

FOR PR REVIEWER ONLY:

[ ] I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

github-actions[bot] commented 6 months ago

Size Change: -55 B (0%)

Total Size: 197 kB

Filename	Size	Change
`./build/index.js`	122 kB	-55 B (0%)

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `./build/53.js` | 1.05 kB | | `./build/index.css` | 883 B | | `./build/marketing.js` | 58 kB | | `./build/payment-gateway-suggestions.css` | 1.25 kB | | `./build/payment-gateway-suggestions.js` | 6.46 kB | | `./build/plugins.js` | 3.92 kB | | `./build/style-index.css` | 2.15 kB | | `./build/style-marketing.css` | 805 B |

_{compressed-size-action}

PanosSynetos commented 6 months ago

Click on "Yes please"

I'm not sure how to get to this point, so I might leave this for @ilyasfoo or @chihsuan to test this out.

I can code review the PHP part, what do you think @kloon ?

kloon commented 6 months ago

I'm not sure how to get to this point, so I might leave this for @ilyasfoo or @chihsuan to test this out.

I was also unsure but found you need to upgrade away from a trial site for this to show.

Also noticing some of the text are not reflecting the updates, might be due to the sync/build process not generating new po/mo files

I can code review the PHP part, what do you think @kloon ?

That would be fine.

Automattic / wc-calypso-bridge