Entrepreneur Signup Flow: Update `is_woo_express` logic to consider eCommerce plan

ivan-ottinger commented 4 months ago

Changes proposed in this Pull Request:

make wc_calypso_bridge_is_woo_express_plan() return true even wc_calypso_bridge_is_ecommerce_plan() is true (i.e. when the site is upgraded to the normal eCommerce plan); this allows the user to the AI assembler.

Before	After

ℹ️ Later (once the new flow is launched) we may want to update the naming of wc_calypso_bridge_is_woo_express_plan(); that's something we touched on briefly with @yansern when discussing the changes.

Post-merge TODO:

[x] make sure the change is available in production in wpcomsh

Related PT: pdDOJh-3iE-p2. Closes https://github.com/Automattic/wp-calypso/issues/89893.

[ ] This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

[x] Have you followed the Writing high-quality testing instructions guide?

Follow the steps outlined in pdDOJh-3ob-p2 and create a test site with Entrepreneur plan (the plan can be added through SA).
Navigate to the WooCommerce Admin page at /wp-admin/admin.php?page=wc-admin and check that the AI tool is not available in the launchpad (Before screenshot above).
Check out the changes proposed in this PR and sync them to your test site (pdDOJh-3ob-p2 → section titled "Sync to your WoA test site").
Reload the WooCommerce Admin page at /wp-admin/admin.php?page=wc-admin.
The AI tool should now be available in the launchpad (After screenshot above). Try to click the CTA button and use the AI tool. It should work correctly.

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes, as applicable?

FOR PR REVIEWER ONLY:

[ ] I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

github-actions[bot] commented 4 months ago

Size Change: 0 B

Total Size: 197 kB

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `./build/53.js` | 1.05 kB | | `./build/index.css` | 883 B | | `./build/index.js` | 122 kB | | `./build/marketing.js` | 58 kB | | `./build/payment-gateway-suggestions.css` | 1.25 kB | | `./build/payment-gateway-suggestions.js` | 6.46 kB | | `./build/plugins.js` | 3.92 kB | | `./build/style-index.css` | 2.15 kB | | `./build/style-marketing.css` | 805 B |

_{compressed-size-action}

ivan-ottinger commented 4 months ago

Hey @yansern 👋🏼 When it comes to pushing these changes to production (once approved), is the goal to get them there right away? Or are we waiting for something more to come in first? 🤔

Just asking because this change will basically make the AI tool available to all existing WordPress.com eCommerce sites - so just making sure this is what we want to make happen at this time.

yansern commented 4 months ago

Hey @yansern 👋🏼 When it comes to pushing these changes to production (once approved), is the goal to get them there right away? Or are we waiting for something more to come in first? 🤔

Just asking because this change will basically make the AI tool available to all existing WordPress.com eCommerce sites - so just making sure this is what we want to make happen at this time.

IMO, there's no harm in making AI available for existing eCommerce plans, but perhaps we can additionally check for wpcom_is_entrepreneur_signup just to limit it first.

ivan-ottinger commented 4 months ago

IMO, there's no harm in making AI available for existing eCommerce plans, but perhaps we can additionally check for wpcom_is_entrepreneur_signup just to limit it first.

Just noting that in our latest call we agreed on keeping the wc_calypso_bridge_is_ecommerce_plan() check in.

ivan-ottinger commented 4 months ago

Thanks for the review and merge, Yan.

I have created a dedicated GH task for clean up of the wc_calypso_bridge_is_woo_express_plan: https://github.com/Automattic/dotcom-forge/issues/6800.

Now I am going to take a look at how the change can be deployed.

yansern commented 4 months ago

Now I am going to take a look at how the change can be deployed.

Thanks! Let me know how it goes! Needs a version bump in both here and wpcomsh.

Automattic / wc-calypso-bridge