Closed ivan-ottinger closed 4 months ago
Size Change: 0 B
Total Size: 197 kB
Hey @yansern 👋🏼 When it comes to pushing these changes to production (once approved), is the goal to get them there right away? Or are we waiting for something more to come in first? 🤔
Just asking because this change will basically make the AI tool available to all existing WordPress.com eCommerce sites - so just making sure this is what we want to make happen at this time.
Hey @yansern 👋🏼 When it comes to pushing these changes to production (once approved), is the goal to get them there right away? Or are we waiting for something more to come in first? 🤔
Just asking because this change will basically make the AI tool available to all existing WordPress.com eCommerce sites - so just making sure this is what we want to make happen at this time.
IMO, there's no harm in making AI available for existing eCommerce plans, but perhaps we can additionally check for wpcom_is_entrepreneur_signup
just to limit it first.
IMO, there's no harm in making AI available for existing eCommerce plans, but perhaps we can additionally check for wpcom_is_entrepreneur_signup just to limit it first.
Just noting that in our latest call we agreed on keeping the wc_calypso_bridge_is_ecommerce_plan()
check in.
Thanks for the review and merge, Yan.
I have created a dedicated GH task for clean up of the wc_calypso_bridge_is_woo_express_plan
: https://github.com/Automattic/dotcom-forge/issues/6800.
Now I am going to take a look at how the change can be deployed.
Now I am going to take a look at how the change can be deployed.
Thanks! Let me know how it goes! Needs a version bump in both here and wpcomsh.
Changes proposed in this Pull Request:
wc_calypso_bridge_is_woo_express_plan()
returntrue
evenwc_calypso_bridge_is_ecommerce_plan()
istrue
(i.e. when the site is upgraded to the normal eCommerce plan); this allows the user to the AI assembler.ℹ️ Later (once the new flow is launched) we may want to update the naming of
wc_calypso_bridge_is_woo_express_plan()
; that's something we touched on briefly with @yansern when discussing the changes.Post-merge TODO:
Related PT: pdDOJh-3iE-p2. Closes https://github.com/Automattic/wp-calypso/issues/89893.
How to test the changes in this Pull Request:
/wp-admin/admin.php?page=wc-admin
and check that the AI tool is not available in the launchpad (Before screenshot above)./wp-admin/admin.php?page=wc-admin
.Other information:
FOR PR REVIEWER ONLY: