Automattic / wc-calypso-bridge

20 stars 4 forks source link

eCommerce Signup Flow: Update eCommerce plan Welcome note #1471

Closed ivan-ottinger closed 5 months ago

ivan-ottinger commented 5 months ago

Changes proposed in this Pull Request:

Markup on 2024-05-17 at 16:33:16

Related to https://github.com/Automattic/dotcom-forge/issues/7220

How to test the changes in this Pull Request:

The changes proposed in this PR are targeting Entrepreneur Trial plan, however, due to technical limitations, we will only perform a partial test on a "full" Entrepreneur plan site.

If you don't have your WoA test site yet, please follow the steps outlined in pdDOJh-3ob-p2 and create a test site with Entrepreneur plan (the plan can be added through the SA).

  1. Check out the PR and sync it with your WoA test site on an Entrepreneur plan.
  2. Revert the last two commits to apply the temporary test code:
    • git revert 063b1660714c917fa0f78b45c9a0fe4152c4c5e3
    • git revert 6352e53ed72aa98eef473ef156991f2c8af42183 (I wanted to keep the changes in one commit, but forgot one line)
  3. Navigate to /wp-admin/admin.php?page=wc-admin and review the Welcome note. It should include correct copy - as can be seen in the screenshot above.

Other information:

FOR PR REVIEWER ONLY:

github-actions[bot] commented 5 months ago

Size Change: 0 B

Total Size: 197 kB

ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `./build/53.js` | 1.05 kB | | `./build/index.css` | 883 B | | `./build/index.js` | 122 kB | | `./build/marketing.js` | 58 kB | | `./build/payment-gateway-suggestions.css` | 1.25 kB | | `./build/payment-gateway-suggestions.js` | 6.46 kB | | `./build/plugins.js` | 3.92 kB | | `./build/style-index.css` | 2.15 kB | | `./build/style-marketing.css` | 805 B |

compressed-size-action

yansern commented 5 months ago

Test works fine. Code look good.

ivan-ottinger commented 5 months ago

Test works fine. Code look good.

Thank you, Yan! 🙇🏼


The changes introduced in this PR will be released as part of https://github.com/Automattic/wc-calypso-bridge/pull/1474.

ivan-ottinger commented 4 months ago

New strings have been translated: