Open yuliyan opened 3 months ago
Size Change: 0 B
Total Size: 197 kB
Does this mean that we have to remove the node modules directory, so that it isn't packaged up in the release afterwards?
The node_modules
directory is removed when building the app in the create-release
script.
Does this mean that we have to remove the node modules directory, so that it isn't packaged up in the release afterwards?
The
node_modules
directory is removed when building the app in thecreate-release
script.
I simulated a pre-release by bumping the version and updating the changelog, but exited the process before creating the pull request.
diff --git a/.sshyncignore b/.sshyncignore
new file mode 100644
index 0000000..353e57b
--- /dev/null
+++ b/.sshyncignore
@@ -0,0 +1,7 @@
+.git
+node_modules/
+tests/
+vendor/
+.cache/
+.idea
+.config
It seems that the Git commands in these scripts are adding files that were not initially tracked, ~or were even marked to be ignored in the .gitignore file.~
Other than that, LGTM!
@markbiek, since you've worked on the script before, could you confirm if it's ok to build the app before running the prep-release.js
script?
Changes proposed in this Pull Request:
The
update-translations
command of theprep-release
script will scan the directory for translatable strings, including thebuild
directory, which can either be outdated or not existing at all, resulting in excluding strings from the generated POT file.This PR updates the
npm run prepare-release
script to addnpm run build
prior to executing theprep-release.js
script to ensure the build directory is up to date when scanning for translatable strings.How to test the changes in this Pull Request:
Other information:
FOR PR REVIEWER ONLY: