Automattic / wc-calypso-bridge

20 stars 4 forks source link

eCommerce Signup Flow: Add the "Welcome" note back #1484

Closed ivan-ottinger closed 2 months ago

ivan-ottinger commented 3 months ago

⚠️ Please do not merge until June 7th, 2024 ⚠️


Changes proposed in this Pull Request:

Related to https://github.com/Automattic/dotcom-forge/issues/7220.

331631991-a4fbe1d7-386c-4ffb-9b12-e96442d0a532

How to test the changes in this Pull Request:

The changes proposed in this PR are targeting Entrepreneur Trial plan, however, due to technical limitations, we will only perform a partial test on a "full" Entrepreneur plan site.

If you don't have your WoA test site yet, please follow the steps outlined in pdDOJh-3ob-p2 and create a test site with Entrepreneur plan (the plan can be added through the SA).

  1. Check out the PR and sync it with your WoA test site on the Entrepreneur plan.
  2. Revert the last commit to apply the temporary test code: git revert fd855cae32da54f4bb4e7209e368fecd1892fe57
  3. Navigate to /wp-admin/admin.php?page=wc-admin and review the Welcome note. It should include correct copy - as can be seen in the screenshot above.

Other information:

FOR PR REVIEWER ONLY:

github-actions[bot] commented 3 months ago

Size Change: 0 B

Total Size: 200 kB

ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `./build/53.js` | 1.08 kB | | `./build/index.css` | 883 B | | `./build/index.js` | 126 kB | | `./build/marketing.js` | 58 kB | | `./build/payment-gateway-suggestions.css` | 1.25 kB | | `./build/payment-gateway-suggestions.js` | 6.56 kB | | `./build/plugins.js` | 3.92 kB | | `./build/style-index.css` | 2.15 kB | | `./build/style-marketing.css` | 805 B |

compressed-size-action

ivan-ottinger commented 3 months ago

Since the new eCommerce flow was launched on May 23rd (pdDOJh-3iE-p2#comment-2647), there will still be users on the Woo Express Trial plan. While the Welcome note shouldn't display to them anyways, I will merge this PR this Friday (just in case).