search

Automattic / wc-calypso-bridge

20 stars 4 forks source link

[LYS] Disable launch your store on trial sites #1504

Closed ilyasfoo closed 1 week ago

ilyasfoo commented 2 weeks ago

Issue Description

Launch your store is not supported for trial sites since trial sites cannot be viewed by the public. I think the following has to be done, but @adrianduffell please let me know if it's desirable:

Alternatively, we could disable the launch-your-store feature flag, but it'll be a tech debt since we eventually may remove the feature flag altogether.

Acceptance criteria

  1. Apply all of above for trial plans (both ecommerce and business trial plans)
beaulebens commented 2 weeks ago

If it doesn't create too much more work, it seems like "Launch Your Store" is the perfect time to tell users that they need to upgrade/pay so that they can actually launch. Not sure exactly what it should look like, but imagine it being like a "blocker" task in the LYS UI somewhere.

ilyasfoo commented 2 weeks ago

@beaulebens Makes sense for a task to tell users to upgrade since it's the end of the trial setup flow. Engineering wise, it may be relatively simple UI work, but I think we may need design's input to make it effective.

For reference, currently the launch task is a dummy "disabled" task on trial sites (screenshot).

beaulebens commented 2 weeks ago

Ah I see in the screenshot it's contextually linked with [Upgrade] to make it clear you need to do that before you can Launch, so that's probably OK. Thanks.

adrianduffell commented 1 week ago

Hide Site visibility settings tabs

I think it would be good to keep the tab visible to keep it consistent with screenshots and video tutorials. Perhaps it is another opportunity to place an upgrade message and maybe disable the save button or hide the form altogether 🤔

ilyasfoo commented 1 week ago

I think it would be good to keep the tab visible to keep it consistent with screenshots and video tutorials. Perhaps it is another opportunity to place an upgrade message and maybe disable the save button or hide the form altogether 🤔

Good point, @adrianduffell! I think it makes sense 👍

Should be appropriate for a follow-up