Automattic / wc-calypso-bridge

20 stars 4 forks source link

Fix LYS badge override #1517

Closed ilyasfoo closed 1 month ago

ilyasfoo commented 1 month ago

Changes proposed in this Pull Request:

Closes https://github.com/Automattic/wc-calypso-bridge/issues/1516

This PR fixes LYS badge style overridden by default admin color scheme.

I used nav-unification.css because I didn't want to add a new globally-loaded CSS for a mere couple lines fix.

Before

image image

After

image image

How to test the changes in this Pull Request:

  1. Use a WPCOM atomic e-commerce site
  2. Enable LYS feature flag (you can set these lines to true).
  3. Go to /wp-admin/profile.php
  4. Select Default admin color scheme and click Update Profile
  5. Hover the LYS badge
  6. Observe that it does not have a black background color
  7. Go to Settings > WooCommerce > Site visibility
  8. If it was Live, set to Coming soon, and vice versa. Click Save changes
  9. Hover the LYS badge
  10. Observe that it does not have a dark background color

Other information:

FOR PR REVIEWER ONLY:

github-actions[bot] commented 1 month ago

Size Change: 0 B

Total Size: 201 kB

ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `./build/53.js` | 1.08 kB | | `./build/index.css` | 878 B | | `./build/index.js` | 126 kB | | `./build/marketing.js` | 58.3 kB | | `./build/payment-gateway-suggestions.css` | 1.24 kB | | `./build/payment-gateway-suggestions.js` | 6.57 kB | | `./build/plugins.js` | 3.93 kB | | `./build/style-index.css` | 2.15 kB | | `./build/style-marketing.css` | 800 B |

compressed-size-action