Automattic / woocommerce-payments

Accept payments via credit card. Manage transactions within WordPress.
https://wordpress.org/plugins/woocommerce-payments/
Other
174 stars 69 forks source link

Manual subscription renewals with the UPE #2398

Open FangedParakeet opened 3 years ago

FangedParakeet commented 3 years ago

Currently, the payment method Giropay is disabled for purchases of subscription products, since it does not support saving payment methods. However, if manual subscription renewals are enabled in WC Subscriptions, even payment methods that do not support recurring payments can be used to purchase subscription products. In order to renew subscription products with single-use payment methods, the customer must return to their account page to manually renew the subscription and process a one-time payment at each scheduled interval.

The existing card gateway saves the payment method in all subscription transactions, even if manual subscription renewal is mandatory. This creates no issues with Stripe's card payment method, but performing this with Giropay will throw an error. This issue is to resolve that problem and make Giropay, specifically since this is the only payment method that will not support recurring payments, compatible with manual subscription renewals.

Here is a list of tasks and concerns related to this issue.

Relevant Slack thread: p1625863564015100-slack-C022N4CHJ65

jessy-p commented 10 months ago

@FangedParakeet could you please take a look at this issue and close if obsolete or if not intended to be addressed in near future.

jessy-p commented 9 months ago

This issue impacts WC Payments Subscriptions so assigning to Quark (based on team responsibilities Pc2DNy-3z-p2) @diego373. Assigning as part of Gamma Triage process PcreKM-yM-p2.

FangedParakeet commented 9 months ago

Apologies for my incredibly belated response on this issue.

If manual subscription renewals is enabled, Giropay should be enabled at checkout and the option to save payment method should not be selected.

AFAICT, this is still currently the case; however, this limitation may be on the onus of the implementation of the checkout payment method. It appears that the payment method is not yet aware of the manual subscription setting and if any subscription is present in the cart, we will not present any payment method that would otherwise not support subscription payments. Sadly I lack the context of whether this is by design or by accident.

CC'ing @diegocurbelo, because I believe there has been a case of mistaken identity and an imposter Diego has unfortunately been pinged above. Let me know if you feel the behaviour described in this issue is still unexpected, whether it should be corrected, and whether you feel it lies in your team's domain or would you rather us take on the ticket, having more insight into how payment methods are enabled at checkout. 🙏