search

Automattic / woocommerce-payments

Accept payments via credit card. Manage transactions within WordPress.
https://wordpress.org/plugins/woocommerce-payments/
Other
174 stars 69 forks source link

Display payment methods brand image #298

Closed luizreis closed 4 years ago

luizreis commented 4 years ago

Display payment methods brand image in transaction list and payment details. Current implementation renders the brand name inside of a code tag.

dechov commented 4 years ago

Should we get these from https://github.com/woocommerce/woocommerce-gateway-stripe/tree/master/assets/images?

@LevinMedia IIRC you had good versions of these assets or may have had an idea of where to get them?

luizreis commented 4 years ago

Should we get these from https://github.com/woocommerce/woocommerce-gateway-stripe/tree/master/assets/images?

I have experimented with them using a local branch. I followed basically the same pattern as the Stripe extension of using CSS class names and adding the card image. The only issue is that I could not find an unionpay asset in there. Should we worry about it?

I'll create a PR with my local branch. It is almost finished if we're okay using those assets.

luizreis commented 4 years ago

I tidied up what I had locally and pushed it to #305.

cc @dechov @LevinMedia