[Deposits UI] Not All Fees/Charges Listed in Deposit Details (IPP - in person payment fee not shown)

[csmcneill]

Describe the bug

If a user is subject to certain fees, like the $1/month active card reader fee, it is not itemized under the deposit details at Payments > Deposits

To Reproduce

1. Have a WCPay account
2. Use a WooCommerce In-Person Payments or WooCommerce In-Person Payments WisePad 3
3. Wait for a deposit
4. Note that the deposit is $1 less than expected
5. Check the deposit details at Payments > Deposits
6. Note that the fee isn't listed.

Actual behavior

There is a discrepancy between the expected and actual deposit. The total deposit amount listed under Payments > Deposits may be correct, but there's no indication that a fee was deducted from the total deposit amount.

Screenshots

Expected behavior

All fees, including but not limited to those related to active card readers, should be listed in the deposit details at Payments > Deposits.

Additional context

Reported in 5778360-zen

[haszari]

We need to ensure all fees etc that affect the payout amount are surfaced in the UI. We can fix this as maintenance or in upcoming project.

[maxlaf]

6371508-zen

[shendy-a8c]

To whoever works on this issue needs to confirm that this issue is a duplicate of https://github.com/Automattic/woocommerce-payments/issues/6169 and if so, needs to close one of the issues.

[kalessil]

It's an active terminal readers fee, which is billed directly from a connected account. Those fees are not in the deposits domain, as per my understanding.

To not lose the topic, added it to our "periscope" post - pdjVC1-1Pi-p2.

[brucealdridge]

@kalessil it's worth noting that this affects other areas too including instant deposits and loans.

[Jinksi]

Un-assigning myself to indicate that this issue is available to progress in my absence.

I have not yet reproduced the issue, although I did make progress setting up tap-to-pay on iOS (my first time testing IPP).

[haszari]

Marking as medium priority, assuming that the number of affected merchants (using in-person payments card reader) is a subset of merchants. FYI @souravdebnath1986 feel free to adjust priority. As noted by @brucealdridge this general problem (specific transaction types not listed in deposit detail) also applies to loans and instant deposits. Both of these are used by a subset of merchants.

Shifting back to backlog for now, we can pick up at appropriate priority. (was originally prioritised for Sprint 12 2023)

@Jinksi @kalessil do you know of any technical blockers to adding IPP fees to the deposit detail screen?

Also please comment if there are blockers for other specific transaction types (e.g. loans, instant deposit fees, etc).

[Jinksi]

@Jinksi @kalessil do you know of any technical blockers to adding IPP fees to the deposit detail screen?

Not that I'm aware of at this stage, but I haven't looked far into this. I have not yet progressed past replicating the issue.

[dougaitken]

7594316-zen

[dougaitken]

Another consideration for this - Stripe Capital. It is deducted from per transaction costs so the amount that ends up in the deposit is minus the usual fees PLUS the Capital amount. I believe we should be able to read this from the Capital API.

[kalessil]

@Jinksi @kalessil do you know of any technical blockers to adding IPP fees to the deposit detail screen?

@haszari: frankly, I am not aware of any.

The active terminal readers' charges can be found in wcpay_account_charges/wcpay_test_account_charges, so you should be able to pull succeeded ones using \WCPay\Repository\Account_Charge_Repository::get_account_charges_by_wcpay_account_id and incorporate into the presentation.

[francoishvz]

7660571-zen

[haszari]

A closely related issue ( Automattic/woocommerce-payments-server#4081 ) has been reassigned to @Automattic/pulsar or @Automattic/fusion - because the core problem here is that we need to ensure these other transaction types are included in various tables / reports.

With that in mind, I'm removing this from Helix backlog and requesting re-triage.

[m0untaingoat]

8695378-zen

[AashikP]

We discussed this in p1725877092555119-slack-C02BW3Z8SHK

For now, please keep adding merchant reports tho this issue for tracking purposes.