Automattic / woocommerce-payments

Accept payments via credit card. Manage transactions within WordPress.
https://wordpress.org/plugins/woocommerce-payments/
Other
172 stars 69 forks source link

Subscriptions - remove hooks from constructors #7259

Open marcinbot opened 11 months ago

marcinbot commented 11 months ago

Description

See base PR: https://github.com/Automattic/woocommerce-payments/pull/7249

We need to move the hooks from all class constructors to init_hooks and then call that method whenever the class is instantiated (or whenever we need the hooks to be attached, separately from instantiation).

The goal of this is to remove the side effects from constructors and allow us to instantiate classes freely.

Acceptance criteria

CC @Automattic/quark

zmaglica commented 11 months ago

This issue impacts Subscriptions, so assigning to team Quark (based on team responsibilities Pc2DNy-3z-p2) @diegocurbelo . Assigning as part of Gamma Triage process PcreKM-yM-p2.