We need to move the hooks from all class constructors to init_hooks and then call that method whenever the class is instantiated (or whenever we need the hooks to be attached, separately from instantiation).
The goal of this is to remove the side effects from constructors and allow us to instantiate classes freely.
Acceptance criteria
Base the PR on #7249 if not merged yet
Remove the relevant exceptions from dev/phpcs/ruleset.xml
Move the hooks to the new method and call them. Update the code and unit tests accordingly
This issue impacts Subscriptions, so assigning to team Quark (based on team responsibilities Pc2DNy-3z-p2) @diegocurbelo . Assigning as part of Gamma Triage process PcreKM-yM-p2.
Description
See base PR: https://github.com/Automattic/woocommerce-payments/pull/7249
We need to move the hooks from all class constructors to
init_hooks
and then call that method whenever the class is instantiated (or whenever we need the hooks to be attached, separately from instantiation).The goal of this is to remove the side effects from constructors and allow us to instantiate classes freely.
Acceptance criteria
dev/phpcs/ruleset.xml
CC @Automattic/quark