search

Automattic / woocommerce-payments

Accept payments via credit card. Manage transactions within WordPress.
https://wordpress.org/plugins/woocommerce-payments/
Other
174 stars 69 forks source link

RPP / Failures / Cleanup #7426

Open RadoslavGeorgiev opened 1 year ago

RadoslavGeorgiev commented 1 year ago

Description

Make sure all cleanup tasks are executed upon failure within the new payment process.

It seems like the gradual migration to split-UPE with deferred intent is leaving less and less to clean up.

Presently, the only thing that I can find in place regarding cleanup is the following. However, please check the existing payment process, and make sure that no other clean-up tasks need to be performed during cleanup, or if there are, implement them.

https://github.com/Automattic/woocommerce-payments/blob/a19f2b0f38abdbce2946103fc9cfabe2d42684da/includes/class-wc-payment-gateway-wcpay.php#L1053-L1055

Considering that we will never enable the new payment process alongside legacy UPE, that will not be needed.

Acceptance criteria

All cleanup tasks, if any, and except the example above, are executed.

Testing instructions

To be defined, based on the findings from above.

Additional context

Epic: https://github.com/Automattic/woocommerce-payments/issues/6673 Project: paJDYF-9hL-p2

zmaglica commented 11 months ago

Marking as blocked because of Gamma's shift of current priorities.