Open brucealdridge opened 6 months ago
Marking as low priority since this is rare (manual deposits are not supported, only triggered by Woo staff in unusual circumstances).
While there isn't an obvious signal that a deposit is Instant or Manual when automatic is false on the deposit object. Only instant deposits will have an associated deposit fee whereas manual deposits will have 0 for both fee_percentage and fee
@brucealdridge - is this issue fixable in a robust way?
If so, let's prioritise (medium). e.g. if there is unambiguous manual
(not instant) in data/metadata; if we have to infer based on fees, low priority or could possibly close.
We have to infer based on fees or make a change to the server API. Recommend leaving as low priority
Describe the bug
While rare, manual deposits do occur initiated by support when required. These manual deposits are incorrectly labeled as
Instant
in the app due to the assumption that all deposits that aren'tautomatic
are instant.https://github.com/Automattic/woocommerce-payments/blob/88b091f519ae26c504633ae3bf958359317594ed/client/deposits/details/index.tsx#L90-L92
While there isn't an obvious signal that a deposit is
Instant
orManual
whenautomatic
isfalse
on the deposit object. Only instant deposits will have an associated deposit fee whereas manual deposits will have0
for bothfee_percentage
andfee
https://github.com/Automattic/woocommerce-payments/blob/88b091f519ae26c504633ae3bf958359317594ed/client/types/deposits.d.ts#L16-L27
To Reproduce
Instant
in WooPaymentsIncorrectly labeled deposit
Correctly labeled deposit - not service fee.
![image](https://github.com/Automattic/woocommerce-payments/assets/57298/89782192-d8a0-4d8d-95a6-09095c4d1439)