Deposits: All manual deposits are labeled in as `Instant`

[brucealdridge]

Describe the bug

While rare, manual deposits do occur initiated by support when required. These manual deposits are incorrectly labeled as Instant in the app due to the assumption that all deposits that aren't automatic are instant.

https://github.com/Automattic/woocommerce-payments/blob/88b091f519ae26c504633ae3bf958359317594ed/client/deposits/details/index.tsx#L90-L92

While there isn't an obvious signal that a deposit is Instant or Manual when automatic is false on the deposit object. Only instant deposits will have an associated deposit fee whereas manual deposits will have 0 for both fee_percentage and fee

https://github.com/Automattic/woocommerce-payments/blob/88b091f519ae26c504633ae3bf958359317594ed/client/types/deposits.d.ts#L16-L27

To Reproduce

1. Manually initiate a deposit via the stripe dashboard or cli for an account
2. See that it is incorrectly labelled as Instant in WooPayments

Incorrectly labeled deposit Correctly labeled deposit - not service fee.

[haszari]

Marking as low priority since this is rare (manual deposits are not supported, only triggered by Woo staff in unusual circumstances).

While there isn't an obvious signal that a deposit is Instant or Manual when automatic is false on the deposit object. Only instant deposits will have an associated deposit fee whereas manual deposits will have 0 for both fee_percentage and fee

@brucealdridge - is this issue fixable in a robust way?

If so, let's prioritise (medium). e.g. if there is unambiguous manual (not instant) in data/metadata; if we have to infer based on fees, low priority or could possibly close.

[brucealdridge]

We have to infer based on fees or make a change to the server API. Recommend leaving as low priority