Display notice on Settings > Payments > Deposits to inform the merchant when their bank account has an error.

jessy-p commented 5 months ago

Description

Display a notice in Settings > Payments > Deposits to inform the merchant when their bank account has an error.

Based on https://github.com/Automattic/woocommerce-payments/issues/6294#issuecomment-1977424883
Similar to the notice displayed on Payments > Overview > Deposits #8321
Dependent on woocommerce-payments-server#4862

Acceptance criteria

When Stripe sets a bank account to errored after a failed deposit, the merchant is informed via a notice on Settings > Payments > Deposits

Designs

TBD

Testing instructions

Test with woocommerce-payments-server#4862
Visit the Stripe Express dashboard for your test WooPayments account (Payments → Overview → Account Details → Edit Details) and update the payout bank account to a failing test account, e.g. 110000000/000111111116
Use the Stripe Shell to create a manual deposit. stripe payouts create --stripe-account="acct_123" --amount="123" --currency="USD"
The bank account would be set to errored.

Dev notes

https://github.com/Automattic/woocommerce-payments/pull/8321 https://github.com/Automattic/woocommerce-payments-server/pull/4862

Additional context

TBD: how to test for multiple currency --> bank account setups.

jessy-p commented 5 months ago

@elizaan36 https://github.com/Automattic/woocommerce-payments/issues/6294#issuecomment-1944434429

Please give input on design and priority.

elizaan36 commented 5 months ago

@jessy-p What's the question?

haszari commented 3 months ago

Marking as high. I don't know how common this is but it seems important that if there is a bank error we show this in UI.

Next steps:

Test/explore to confirm that this is still a problem – i.e. if payout error, no clue in settings.
Prototype / design
- Engineer could implement something using standard patterns / components and/or
- Design could mock up
Implement, test, review ⇒ ship!

haszari commented 3 months ago

Test/explore to confirm that this is still a problem – i.e. if payout error, no clue in settings.

@jessy-p when you have a moment, could you please:

Recheck to confirm this is still a problem.
Update the title and description to clarify how merchant is impacted, how to reproduce.

Then we can prioritise appropriately. Based on the info so far, and the fact that we have fixed some similar issues already (#6294, , I'm unclear if this is common or rare edge case.

elizaan36 commented 1 month ago

👋 I'll have to pass the torch on this one to @rogermattic after today. I'm not clear on the design needs here, so as long as it's on your radar. Thanks Magda!

rogermattic commented 3 weeks ago

Hey @haszari and @jessy-p! This issue is on my radar now and I'm happy to provide the design support as needed :)

Am I understanding this correctly, that we're after a notice message, as described in [this issue] ?(https://github.com/Automattic/woocommerce-payments/issues/6294#issuecomment-1944434429)

More details will be appreciated :)

haszari commented 3 weeks ago

Am I understanding this correctly, that we're after a notice message, as described in [this issue] ?(https://github.com/Automattic/woocommerce-payments/issues/6294#issuecomment-1944434429)

Yes – that comment and the description are a good summary.

TLDR:

Payouts can fail for various reasons.
When they fail, we notify merchant by email.
If merchant doesn't check their email, or is lost/missed, they have no way to know there's a problem.
⇒ So we should show something in WooPayments to give them a heads up.

What more details are you looking for @rogermattic ? Maybe we can discuss in slack.

rogermattic commented 3 weeks ago

Thanks @haszari

What more details are you looking for @rogermattic ? Maybe we can discuss in slack.

No more details needed for now. I'll start working on this as soon as I can.

rogermattic commented 1 week ago

Subject to the final discussion here, these are the designs that we can use:

Inline with the Payments Overview notice...

Payments Overview – Deposit Failure Notice

Figma ->

We should also include the notice in the Account status box (when and if it exists)

Figma ->

and in the Payout Box:

Figma ->

Bonus: In the future, Payouts will have it's own card, so we will have the notice displayed there, and more or less it will look like this:

Payouts - Future state

Automattic / woocommerce-payments