Automattic / woocommerce-payments

Accept payments via credit card. Manage transactions within WordPress.
https://wordpress.org/plugins/woocommerce-payments/
Other
171 stars 68 forks source link

Google Pay button lacks outline when set to Outline theme #8828

Closed pierorocca closed 6 days ago

pierorocca commented 3 months ago

Describe the enhancement

As shown in this recent PRB test, the Google Pay button lacks an outline despite being set to the Outline theme.

To Reproduce

  1. Enable Google Pay
  2. Set button theme to Outline
  3. Observe the preview on Chrome, Google Pay button lacks an outline
  4. On a product, cart, or checkout page with a light background observe that the button lacks an outline

Expected behavior

Google Pay button has an outline in the merchant settings preview and on product, cart, and checkout pages.

pierorocca commented 2 months ago

@bborman22 would you recommend we resolve this in the ECE implementation rather than fixing it in the PRB implementation?

bborman22 commented 2 months ago

Yeah given the timings, this would make more sense as a fix in ECE rollout.

pierorocca commented 1 month ago

@bborman22 also appears that there's no support for Outline for Google Pay on Apple Pay. Is there a way to "fake" an outline?

bborman22 commented 1 month ago

Yeah I can see that it's not an option for Google Pay (wondering if this recently changed?). Given how the button is rendered in an iframe, I don't know of a good way we could fake it. We are doing this exploration around individual ECE renders per button and there might be some ability to add a border around just the Google Pay button if outline is chosen, but I wouldn't consider it very promising as I doubt we'd get a clean look that way.

pierorocca commented 3 weeks ago

Switching to an enhancement since this is not technically a bug.

pierorocca commented 6 days ago

Closing this in favor of a potential enhancement to allow buttons to be themed independently from one another. Rationale - buttons can have n number of themes, different definitions of what "white" or "light" means, and there's no guarantee of overlap. Therefore, trying to normalize this is futile.