search

Automattic / woocommerce-payments

Accept payments via credit card. Manage transactions within WordPress.
https://wordpress.org/plugins/woocommerce-payments/
Other
173 stars 69 forks source link

[ECE] Button max-height is 55px due to constraints in Stripe's API #9006

Closed reykjalin closed 2 months ago

reykjalin commented 3 months ago

Description

I reacted too quickly to the 55px and didn't think of the repercussions to other gateway's buttons sizes which have slowly been adhering to our design guidelines. Let me spin up a conversation with @nikkivias and Stripe.

Originally posted by @pierorocca in https://github.com/Automattic/woocommerce-payments/issues/8951#issuecomment-2183177946

This issue is mostly for tracking a resolution here. Either Stripe fix the maximum allowed height (we need it to be 56px to be consistent with previous designs), or we need to adjust the max height for all payment gateways.

pierorocca commented 3 months ago

As noted elsewhere, we'll need to move to 55px and the external design guideline are being updated to note the change.

bborman22 commented 2 months ago

Hey team! Please add your planning poker estimate with Zenhub @asumaran @cesarcosta99 @lovo-h @rafaelzaleski @reykjalin @ricardo