Epic: Update Transactions Reports pages to use merchant timezone

Automattic / woocommerce-payments

Accept payments via credit card. Manage transactions within WordPress.

https://wordpress.org/plugins/woocommerce-payments/

Other

173 stars 69 forks source link

Epic: Update Transactions Reports pages to use merchant timezone #9064

Closed jessy-p closed 3 months ago

jessy-p commented 3 months ago

Update all Transactions Reports page to use merchant timezone, currently it uses UTC
Also check, server and client side CSV downloads.
Ref: pdjTHR-3N2-p2#comment-5426

haszari commented 3 months ago

Current status:

All (AFAIK) reports are in UTC, though not labelled.
CSVs is in UTC.
- There are already issues logged for this inconsistency, need clarity from design/product on this.
- We are kinda assuming merchant timezone, kinda based on payment activity widget.
Payment activity card is in merchant timezone.

haszari commented 3 months ago

We estimated this based on a few assumptions:

We want all dates in list views and CSVs to be in store timezone.
- The timezone used by activity widget – exploring /confirming if this timezone/setting is right it is out of scope. But we should confirm what setting we are using. We suspect this is user timezone (i.e. observer of the report).
We don't know which need fixes, assuming all.
- Transactions, disputes, deposits, transaction timeline, capital loans.

Jinksi commented 3 months ago

We should align with WooCommerce analytics handling of timezones, which appears to use the timezone of the store/site set in WP settings.

haszari commented 3 months ago

We should align with WooCommerce analytics handling of timezones, which appears to use the timezone of the store/site set in WP settings.

That would work great for the "sales reps around the world discussing sales numbers" use case!

aheckler commented 3 months ago

We might also need to adjust whatever transaction batching we use for tax document generation? This doc mentions that the tax documents use UTC for reports.

NOTE: The transaction data used in the invoice is based on the UTC timezone, which may cause some discrepancies between the transactions list and the invoice.

haszari commented 3 months ago

Linking in an issue which clearly describes the bug/problem – this issue is a fix/solution, and we ended up deciding on a different approach.

https://github.com/Automattic/woocommerce-payments-server/issues/5868

haszari commented 3 months ago

We can probably close this. We still want to do it, but it's a roadmap item, not a bug.

haszari commented 3 months ago

I'm closing this epic, so we don't get confused :)

I've added all relevant steps/work to the other epic (UTC approach):

https://github.com/Automattic/woocommerce-payments-server/issues/5858