Automattic / woocommerce-payments

Accept payments via credit card. Manage transactions within WordPress.
https://wordpress.org/plugins/woocommerce-payments/
Other
171 stars 69 forks source link

[ECE] Finalize button presentation and design #9066

Closed reykjalin closed 1 month ago

reykjalin commented 1 month ago

Description

There are still several issues with the ECE (Stripe's Express Checkout Element) presentation that we need to work through:

### Tasks
- [x] https://github.com/Automattic/woocommerce-payments/issues/9006 - Here we need to update the max height across all express payment buttons in WooPayments, including ECE.
- [x] https://github.com/Automattic/woocommerce-payments/issues/9005 - The ECE buttons don't have the correct width in Storefront.
- [x] When WooPay and ECE buttons are rendered on the same page [there's an uneven gap](https://github.com/Automattic/woocommerce-payments/issues/8951#issuecomment-2182004929) between the buttons that [we've been unable to track down](https://github.com/Automattic/woocommerce-payments/issues/8951#issuecomment-2183475932).
- [ ] #8136

Acceptance criteria

Designs

Testing instructions

See relevant issues and discussions.

Dev notes

Additional context

pierorocca commented 1 month ago

Hey team could we also add this issue @rafaelzaleski has picked up to this list? https://github.com/Automattic/woocommerce-payments/issues/8136

It would look good on the team in the feature announcement and showcase if this new implementation avoids this very noticeable font size mismatch.

haszari commented 1 month ago

What's ECE? Recommend defining the acronym somewhere on these issues for newbies like me :)

AHA! Express Checkout Element https://github.com/Automattic/woocommerce-payments/issues/8768

bborman22 commented 1 month ago

Closing the epic for ECE design issues that were discovered. Thanks for the great work everyone!