search

Automattic / woocommerce-payments

Accept payments via credit card. Manage transactions within WordPress.
https://wordpress.org/plugins/woocommerce-payments/
Other
174 stars 69 forks source link

Google & Apple Pay buttons are displayed in editor even when the payment method is disabled #9444

Open alexflorisca opened 1 month ago

alexflorisca commented 1 month ago

Describe the bug

The Google & Apple Pay buttons are displayed in editor even when the payment method is disabled in WooPayments settings.

To Reproduce

  1. In wp-admin, go to WooCommerce > Settings > Payments > WooPayments page
  2. Disable Apple / Google Pay
  3. Open the checkout page in the editor
  4. See that the Apple & Google pay buttons are still rendered in the editor

Actual behavior

The Apple and Google Pay buttons are visible in the editor when they are disabled in settings.

Screenshots

Expected behavior

The Apple and Google Pay buttons should not be visible in the editor when they are disabled in settings.

Potential solution

We should only call registerExpressPaymentMethod if it is enabled from the WooPayments settings page

CodingWithError commented 1 month ago

hey can you give more clarification on this i am unable to find a settings page on the main website

alexflorisca commented 2 weeks ago

hey can you give more clarification on this i am unable to find a settings page on the main website

I've edited the steps to reproduce above to be a bit clearer. Let me know if you still have an issue to reproduce. Perhaps the following video is also useful

https://github.com/user-attachments/assets/a9203513-8e6f-4e45-8618-713d7d383f0e

CodingWithError commented 2 weeks ago

Assign this to me I will try to work on this.

gpressutto5 commented 1 day ago

Hi @CodingWithError, thanks for your interest in helping. Do you still plan on working on this issue? If not, I'll assign it to myself.

gpressutto5 commented 16 hours ago

Please add your planning poker estimate with Zenhub @FangedParakeet