Closed frosso closed 3 days ago
9744
or branch name refactor/express-checkout-button-ui-utility
in your-test.site/wp-admin/admin.php?page=jetpack-beta&plugin=woocommerce-payments :rocket: Launch a JN site with this branch :rocket:
:information_source: Install this Tampermonkey script to get more options.
Build info:
Note: the build is updated when a new commit is pushed to this PR.
Size Change: +42 B (0%)
Total Size: 1.33 MB
Filename | Size | Change |
---|---|---|
release/woocommerce-payments/dist/express-checkout.js |
14.9 kB | +42 B (0%) |
Fixes #
Changes proposed in this Pull Request
In the "Tokenized Paymenr Request" implementation, we had a "Button UI" class, which allows to interact with the jQuery elements around the button and slimmed a bit the wcPayEce class from some methods: https://github.com/Automattic/woocommerce-payments/blob/0df81cc8f4ddf157dcb2a12c72a410e80ed2b9c3/client/tokenized-payment-request/button-ui.js
I'd like to bring it to the ECE implementation, so it can also be reflected in the Tokenized ECE implementation.
I didn't isolate these changes to the Tokenized ECE implementation for a couple of reasons:
I'll also copy the same changes to the tokenized ECE ( https://github.com/Automattic/woocommerce-payments/tree/develop/client/tokenized-express-checkout ), once this is merged.
Since this is just moving the methods in an isolated class, the same test coverage should be present as before.
Testing instructions
The changes don't affect block-based elements (like block-based cart/checkout). These changes affect product page, shortcode cart & checkout, pay-for-order.
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge