Closed frosso closed 2 days ago
9745
or branch name refactor/express-checkout-initialization-page-location
in your-test.site/wp-admin/admin.php?page=jetpack-beta&plugin=woocommerce-payments :rocket: Launch a JN site with this branch :rocket:
:information_source: Install this Tampermonkey script to get more options.
Build info:
Note: the build is updated when a new commit is pushed to this PR.
Size Change: -14 B (0%)
Total Size: 1.33 MB
Filename | Size | Change |
---|---|---|
release/woocommerce-payments/dist/express-checkout.js |
14.9 kB | -13 B (0%) |
release/woocommerce-payments/dist/tokenized-express-checkout.js |
14.9 kB | -1 B (0%) |
Fixes #
Changes proposed in this Pull Request
Keeping consistent the retrieval of
window.wcpayExpressCheckoutParams
. This refactor opportunity was already brought up during the review process of the tokenized cart for the PRBs.Instead of accessing
window.wcpayExpressCheckoutParams
directly, we'll just use thegetExpressCheckoutData()
utility.Since the
is_pay_for_order
/is_checkout_page
/is_product_page
provide the same information asbutton_context
, I also removed all instances of such booleans in favor ofbutton_context
.Testing instructions
There shouldn't be a difference in functionality, here. Since this is affecting the shortcode-based cart/checkout and the product pages, you could check if they're still working.
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge