Automattic / woocommerce-payments

Accept payments via credit card. Manage transactions within WordPress.
https://wordpress.org/plugins/woocommerce-payments/
Other
176 stars 69 forks source link

QIT authentication fails if password contains spaces #9750

Open dmallory42 opened 1 week ago

dmallory42 commented 1 week ago

Describe the bug

When trying to set up QIT (see: PaJDYF-6n7-p2), I noticed that we pass the password string (which is set in an env file) in via the common.sh script without " quoting it. This means, if the password contains a space, it gets parsed as a new word rather than the same string, causing the script to fail.

To Reproduce

  1. On develop, use a password with a space in it in the local.env file for the QIT_PASSWORD variable (it doesn't need to be the correct password to see this error).
  2. You should see an error similar to: ` No arguments expected for "partner:add" command, got "".