search

Automattic / woocommerce-services

WooCommerce Services is a feature plugin that integrates hosted services into WooCommerce (3.0+), and currently includes automated tax rates and the ability to purchase and print USPS shipping labels.
GNU General Public License v2.0
107 stars 20 forks source link

Let non-master Jetpack admins accept TOS #1653

Open geeklore opened 5 years ago

geeklore commented 5 years ago

P2 thread here

On VIP Go, Jetpack needs to be connected via our Master User. (wpcomvip)

When the site owner logs in they are not presented with a banner to accept the TOS. That’s because the check here is failing.

https://github.com/Automattic/woocommerce-services/blob/bcbcd1510d03d1d2b1d245b66de48e45d8140a94/classes/class-wc-connect-nux.php#L416-L419

To accept the TOS, you have to be the Primary, or Master User. Which of course the Admin is not.

https://github.com/Automattic/woocommerce-services/blob/bcbcd1510d03d1d2b1d245b66de48e45d8140a94/classes/class-wc-connect-nux.php#L193-L197

This of course means that the plugin is not functional, there are no setting pages, etc.

This also means that the site owner won’t be able to add a credit card and purchase labels since WCS pulls the credit cards from the account of a user that initiated the Jetpack connection.

We have a customer that is currently facing this dilemma and wondering what kind of a solution might work best.

Also wanted to mention that we found that validate_plugin( 'jetpack/jetpack.php' ) is failing.

Checking the list of active plugins instead: get_option('active_plugins') might be better because code-activated plugins and mu-plugins won’t fit that check in WCS

https://github.com/Automattic/vip-go-mu-plugins/blob/66efdecc7ce59c5deb4bccd5543c3b00c9c6638b/vip-plugins/vip-plugins.php#L169-L182

geeklore commented 5 years ago

@dwainm Would you be able to make a guess at when this might get looked at? The customer would like to know so they can move on to a different solution if it's not going to be any time soon.

laurendavissmith commented 5 years ago

Dupe of #1393 but keeping this one since there more details. We need to solve this in a generic way and not just for VIP customers

v18 commented 5 years ago

Ref: p7bbVw-2w7-p2

chrislevine24 commented 2 years ago

Has there been any progress on this? It's been some time and the problem is still there.

amandasjackson commented 1 year ago

another report 164312-zen