Automattic / woocommerce-services

WooCommerce Services is a feature plugin that integrates hosted services into WooCommerce (3.0+), and currently includes automated tax rates and the ability to purchase and print USPS shipping labels.
GNU General Public License v2.0
108 stars 20 forks source link

Get rid of the "Reconnect" modal on Jetpack uninstall #2705

Closed sergeymitr closed 11 months ago

sergeymitr commented 12 months ago

Jetpack used to disconnect other plugins on uninstall. @waclawjacek added a modal to WCS&T suggesting users to reconnect once Jetpack has been uninstalled (#2690), and it was a great solution to a long standing problem.

We have recently modified Jetpack to keep connection active after plugin uninstall, so WCS&T can get rid of the modal now.

There's a condition though. Even though the uninstall code is run from Jetpack's uninstall.php, at that point it loads Connection package from other plugins. Therefore, to make the changes work, Connection package needs to be updated in the WCS&T plugin itself.

Once updated, Jetpack will no longer disconnect other plugins upon uninstall.

More details on that: pf5801-7k-p2

The task list would look like this:

cc @kloon