Open kallehauge opened 3 months ago
Hi @kallehauge ,
After doing some investigating and testing, moving from reactDOM.render()
to createRoot().render()
seems not as easy as I thought and might need more time to do it. We might need to update the node version and change numbers of dependencies. and also will need to fix the testing script.
This is due to the plugin still use the old node version and some of dependencies that this plugin use is outdated.
Will this be ok to continue?
Heya @iyut!
Uf! It makes sense, but it's definitely more than I had originally anticipated to make the change 😄
If we update the version, then we should probably do it in a separate PR; but I'm calling in @kloon to give a verdict on if this is worth spending time on now. AFAIK then we're not in any immediate rush with the React warning.
The last week and a half have been pretty busy, so I'm pinging to make sure it didn't get lost in all the activity: @kloon
We need to update our React entrypoint logic to use
createRoot
instead ofReactDOM.render
(see screenshot below):ReactDOM.render
:/client/main.js