We need to use `createRoot` instead of `render`

Automattic / woocommerce-services

WooCommerce Services is a feature plugin that integrates hosted services into WooCommerce (3.0+), and currently includes automated tax rates and the ability to purchase and print USPS shipping labels.

GNU General Public License v2.0

107 stars 20 forks source link

We need to use `createRoot` instead of `render` #2797

Open kallehauge opened 2 months ago

kallehauge commented 2 months ago

We need to update our React entrypoint logic to use createRoot instead of ReactDOM.render (see screenshot below):

Screenshot 2024-08-14 at 12 48 38

Places where we use ReactDOM.render: /client/main.js
Solution inspiration: https://github.com/woocommerce/woocommerce/pull/48831

iyut commented 2 months ago

Hi @kallehauge ,

After doing some investigating and testing, moving from reactDOM.render() to createRoot().render() seems not as easy as I thought and might need more time to do it. We might need to update the node version and change numbers of dependencies. and also will need to fix the testing script.

This is due to the plugin still use the old node version and some of dependencies that this plugin use is outdated.

Will this be ok to continue?

kallehauge commented 2 months ago

Heya @iyut!

Uf! It makes sense, but it's definitely more than I had originally anticipated to make the change 😄

If we update the version, then we should probably do it in a separate PR; but I'm calling in @kloon to give a verdict on if this is worth spending time on now. AFAIK then we're not in any immediate rush with the React warning.

kallehauge commented 1 month ago

The last week and a half have been pretty busy, so I'm pinging to make sure it didn't get lost in all the activity: @kloon