Automattic / woocommerce-services

WooCommerce Services is a feature plugin that integrates hosted services into WooCommerce (3.0+), and currently includes automated tax rates and the ability to purchase and print USPS shipping labels.
GNU General Public License v2.0
107 stars 20 forks source link

BUG: Migrated packages not recorded in wcshipping_labels meta #2807

Closed samgerdt closed 6 days ago

samgerdt commented 1 week ago

Package templates migrated from Shipping & Tax are not being recognized in this check (lines 249-255, woocommerce-shipping/src/LabelPurchase/LabelPurchaseService.php):

if ( 'individual' === $box_id ) { $label_meta['package_name'] = __( 'Individual packaging', 'woocommerce-shipping' ); } elseif ( isset( $package_lookup[ $box_id ] ) ) { $label_meta['package_name'] = $package_lookup[ $box_id ]['name']; } else { $label_meta['package_name'] = __( 'Unknown package', 'woocommerce-shipping' ); }

All labels using migrated package settings are recording "Unknown package" in meta.

kallehauge commented 1 week ago

Hi @samgerdt! 👋

Thank you for the report ❤️ We'll take a look and get back to you 👍

kallehauge commented 1 week ago

Howdy @samgerdt! I just wanted to let you know that I've created a patch that is in review, so hopefully it goes out with the next release, soon 😃