search

Automattic / woocommerce-services

WooCommerce Services is a feature plugin that integrates hosted services into WooCommerce (3.0+), and currently includes automated tax rates and the ability to purchase and print USPS shipping labels.
GNU General Public License v2.0
108 stars 20 forks source link

Try WC Shipping Modal Tweak #2814

Closed kloon closed 2 months ago

kloon commented 2 months ago

Description

Remove the auto click of the confirm button when the modal opens to give merchants time to read the modal and decide to proceed.

Update the copy of the modal.

Related issue(s)

Steps to reproduce & screenshots/GIFs

delete_option( 'wcshipping_migration_state' );
delete_option( 'wcst_data_migration_required' );
delete_option( 'wcshipping_installation_completed_shown' );
delete_option( 'wcst_data_migration_processes_to_run' );
delete_option( 'wcshipping_version' );

Ensure you have the wcship_migration_supported flag set to true in your development API server.

Checkout this branch and build, visit any wp-admin page like WooCommerce -> Settings and verify the Migration banner shows, click confirm and verify the modal opens and does not auto click the CTA button.

Check the copy looks good and matches the screenshot.

Screenshot 2024-09-12 at 20 51 15

Checklist

kloon commented 2 months ago

@harriswong Thanks for the final feedback. I believe the X indicates closing the modal, whereas the button is dismissing ie indicating you do not want to see this again soon. Same as with clicking outside, the modal will just close. I will go with what we have, but if there are reports, I'd be happy to revisit this.