Automattic / woocommerce-subscriptions-core

Subscriptions core package for WooCommerce
Other
86 stars 32 forks source link

Add support for php8.2 in github action checks #326

Closed brucealdridge closed 1 year ago

brucealdridge commented 1 year ago

Fixes #324

Description

Adds support for php8.2 to the github action checks. As php8.2 is not yet released, this is using a nightly build.

How to test this PR

Review the output of github actions and verify that the unit tests are being run against php 8.2

Product impact

No product impact, development only change.

brucealdridge commented 1 year ago

Note: The checks are currently failing while still being marked as passing. This is to be resolved in #156 and #325

shendy-a8c commented 1 year ago

Note: The checks are currently failing while still being marked as passing. This is to be resolved in https://github.com/Automattic/woocommerce-subscriptions-core/issues/156 and https://github.com/Automattic/woocommerce-subscriptions-core/issues/325

I don't quite understand what you mean especially the "The checks are currently failing" part because I see all GitHub checks are green.

brucealdridge commented 1 year ago

@shendy-a8c the checks are green in github, but the logs are actually showing some errors. Most of these appear to be due to an incorrectly setup database which IMO should cause the checks to fail #156