Automattic / woocommerce-subscriptions-core

Subscriptions core package for WooCommerce
Other
85 stars 31 forks source link

(Re-) calculate taxes for new renewal orders #345

Open dennisnissle opened 1 year ago

dennisnissle commented 1 year ago

Description

When (automatically) adding a new renewal, taxes for the corresponding renewal order should be recalculated. Tax rates in WooCommerce may be subject to change, e.g.:

Is there any reason why taxes are not being (re-) calculated for renewals based on the current settings? For orders where prices do not include taxes this may lead to higher/lower total prices but nevertheless taxes would at least be precise and not wrong.

Testing instructions

  1. Create a new subscription
  2. Update a tax rate, e.g. change percentage
  3. Generate a renewal for the old subscription
  4. See how the renewal does not reflect current tax rates.
ChrissiePollock commented 8 months ago

@haszari We have a merchant in #7524212-zen whose subscription initially included VAT. The subscription was paused then restarted. Upon renewal, VAT was added in addition to the initial cost. Is this a bug?

haszari commented 8 months ago

@diegocurbelo / @Automattic/quark are best to answer your question @ChrissiePollock !

solstudioim commented 7 months ago

The merchant in 7524212-zd-a8c confirmed it's not on us, the culprit was one of their premium plugins.