lkraav
commented
1 year ago Can you paste your exact PHP warning @skunkbad?
I'm also trying to limit available subscription periods to just [ 'month', 'year' ].
foreach( [
'woocommerce_subscription_available_time_periods',
'woocommerce_subscription_periods',
'woocommerce_subscription_trial_periods'
] as $filter ) {
add_filter( $filter, __NAMESPACE__ . '\cxl_remove_subscription_periods' );
}
function cxl_remove_subscription_periods( array $time_periods ): array {
foreach ( [ 'day', 'week' ] as $tp ) {
unset( $time_periods[ $tp ] );
}
return $time_periods;
}I see a problem at wcs_get_non_cached_subscription_ranges() https://github.com/Automattic/woocommerce-subscriptions-core/blob/121ef4b833aa9ae47e91e22389fca8d30057deba/includes/wcs-time-functions.php#L85 which hardcodes period names. This should respect one of the known 3 filters listed above.
Would love to get a core team comment on whether I'm understanding this correctly?
I could file a PR that runs this array through apply_filters woocommerce_subscription_periods (seems like the most general name to me), is that the way to go?
skunkbad
Description of the bug Time periods cannot be removed using the woocommerce_subscription_periods filter that is in the wcs_get_subscription_period_strings function of wcs-time-functions.php. Doing so produces PHP warnings anytime the function is called. The PHP warning comes from the fact that once we remove keys from the periods, and since your code doesn't check for the presence of the key before trying to use it, we get a lot of undefined array key warnings filling up our error logs.
To Reproduce
Expected behavior I expect to remove periods by key without generating PHP warnings
Actual behavior PHP warnings filling up the error logs
Product impact WooCommerce Subscriptions
Additional context Perhaps if your wcs_get_subscription_period_strings function's return statement could check if the array key exists, we could proceed without warnings. Something like this might work:
Also, we are a paying customer. Can verify this if necessary.