search

Automattic / woocommerce-subscriptions-core

Subscriptions core package for WooCommerce
Other
82 stars 29 forks source link

Declare that plugin is compatible with HPOS #393

Open shendy-a8c opened 1 year ago

shendy-a8c commented 1 year ago

At the time when this issue is created, we're not yet ready to declare HPOS compatibility. Hence, the blocked status.

Description

After all the work to make subscriptions compatible with HPOS, declare that it's compatible. How? https://github.com/woocommerce/woocommerce/wiki/High-Performance-Order-Storage-Upgrade-Recipe-Book#declaring-extension-incompatibility Make sure to check if active WC is 7.3 or newer.

I am not sure if the declaration should be in subscriptions-core or in plugins who load subscriptions-core, ie WooCommerce Subscriptions and WooCommerce Payments. Filing this issue here for now. We might need to create issues in each plugins' (WCS and WCPay) repo.

Testing instructions

  1. Activate the plugin (WCS or WCpay).
  2. Enable HPOS.
  3. Make sure no incompatibility warning.
Screenshot 2023-01-24 at 03 00 35

This page, /wp-admin/plugins.php?plugin_status=incompatible_with_feature, should not list the plugin.

Product impact

AashikP commented 1 year ago

We have another request for this in 6387603-zen

erikgeurts commented 1 year ago

In my staging site, I enabled HPOS in order to learn more about the feature. Even though this issue details that WooCommerce Subscriptions is not yet compatible with HPOS, it does not show up in the list of incompatible plugins at /wp-admin/plugins.php?plugin_status=incompatible_with_feature. In fact, that list shows up as entirely empty: image This is on:

In settings, Data store for orders, I've got 'Use the WooCommerce orders tables' selected, and 'Keep the posts table and the orders tables synchronized' enabled.

I do have a couple of other plugins active, some related to WooCommerce, and according to their developers they've all reached HPOS compatibility status.