Automattic / woocommerce-subscriptions-core

Subscriptions core package for WooCommerce
Other
87 stars 33 forks source link

Single Product Template styling for Variable Subscription should be consistent with core WooCommerce styling #424

Open AashikP opened 1 year ago

AashikP commented 1 year ago

Describe the bug

The label for attributes uses td for the Attribute Name while core WooCommerce uses th, giving it a bold styling as opposed to the attribute name in a variable Subscription product.

Variable Subscription: 0DtIXI.png

Variable Product:

DvkqSB.png

Looks like that's coming from this template file https://github.com/Automattic/woocommerce-subscriptions-core/blob/trunk/templates/single-product/add-to-cart/variable-subscription.php#L40

To Reproduce

  1. Create a variable product and add at-least two variations
  2. Creat a variable subscription product (similar format)
  3. Notice that Variable product attribute is in bold
  4. Variable Subscription product attribute name is regular text

Expected behavior

Consistency in styling across product types unless a different style is required.

Actual behavior

Variable Subscription attribute name style does not match variable product style.

Product impact

Additional context

While this is a minor deviation, depending on the theme used on the store and other customizations around products, this may have a bigger impact on the single product page.

Originally reported in 42023746-hc. Then moved to 6089055-zd-woothemes