We're using the woocommerce_can_subscription_be_updated_to_ filter to allow cancelled subscriptions to be activated via the dashboard. While the status can be updated without problem, it's not generally possible to then set a next payment date for these subscriptions. That's because the _schedule_end and _schedule_cancelled values are set and it's not possible to set a scheduled next payment date beyond the schedule end or cancelled dates. This leaves us with active subscriptions that are no longer able to charge customers.
We can account for this in the function that handles the filter override, however, this could be beneficial to any other users who need to do this so that's why I'm mentioning it here.
To Reproduce
Purchase or add a new subscription.
Add a snippet similar to this to enable activation of cancelled subscriptions:
3. Cancel the subscription you just created.
4. Now activate it again. Once it's activated, attempt to set the next payment date. Observe the error at the top of the screen.
Expected behavior
I would expect that an active subscription can set the next payment date.
Actual behavior
It's impossible to set the next payment date which can cause customers to have active subscriptions that are never billed for renewals.
Product impact
Subscribers can continue to use the subscription indefinitely without paying for renewals.
[X] Does this issue affect WooCommerce Subscriptions? yes/no/tbc, add issue ref
[ ] Does this issue affect WooCommerce Payments? yes/no/tbc, add issue ref
Describe the bug
We're using the
woocommerce_can_subscription_be_updated_to_filter to allow cancelled subscriptions to be activated via the dashboard. While the status can be updated without problem, it's not generally possible to then set a next payment date for these subscriptions. That's because the_schedule_endand_schedule_cancelledvalues are set and it's not possible to set a scheduled next payment date beyond the schedule end or cancelled dates. This leaves us with active subscriptions that are no longer able to charge customers.We can account for this in the function that handles the filter override, however, this could be beneficial to any other users who need to do this so that's why I'm mentioning it here.
To Reproduce
/**
@param WC_Subscription $subscription WC_Subscription. */ function allow_cancelled_and_expired_subscriptions_to_become_active( $can_be_updated, $subscription ): bool { if ( $can_be_updated ) { return $can_be_updated; }
return $subscription->has_status( array( 'cancelled', 'expired' ) ); }
Expected behavior
I would expect that an active subscription can set the next payment date.
Actual behavior
It's impossible to set the next payment date which can cause customers to have active subscriptions that are never billed for renewals.
Product impact
Subscribers can continue to use the subscription indefinitely without paying for renewals.
Additional context
Discussed in https://tumblrsubscriptions.wordpress.com/2023/06/23/investigation-into-active-subscriptions-with-no-next-payment-date/
Status Report
``` ### WordPress Environment ### WordPress address (URL): http://localhost:10028 Site address (URL): http://localhost:10028 WC Version: 7.8.0 REST API Version: ✔ 7.8.0 WC Blocks Version: ✔ 10.2.3 Action Scheduler Version: ✔ 3.5.4 Log Directory Writable: ✔ WP Version: 6.2.2 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US External object cache: – ### Server Environment ### Server Info: nginx/1.16.0 PHP Version: 8.1.9 PHP Post Max Size: 1,000 MB PHP Time Limit: 1200 PHP Max Input Vars: 4000 cURL Version: 7.84.0 (SecureTransport) OpenSSL/1.1.1q SUHOSIN Installed: – MySQL Version: 8.0.16 Max Upload Size: 300 MB Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ GZip: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Database ### WC Database Version: 7.8.0 WC Database Prefix: wp_ Total Database Size: 4.55MB Database Data Size: 3.08MB Database Index Size: 1.47MB wp_woocommerce_sessions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_order_itemmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_actions: Data: 0.02MB + Index: 0.11MB + Engine InnoDB wp_actionscheduler_claims: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_groups: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_logs: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_comments: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_options: Data: 2.06MB + Index: 0.03MB + Engine InnoDB wp_postmeta: Data: 0.05MB + Index: 0.03MB + Engine InnoDB wp_posts: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_snippets: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_usermeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_admin_note_actions: Data: 0.05MB + Index: 0.02MB + Engine InnoDB wp_wc_admin_notes: Data: 0.06MB + Index: 0.00MB + Engine InnoDB wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_product_attributes_lookup: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_product_download_directories: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_product_meta_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_wc_rate_limits: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_reserved_stock: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB ### Post Type Counts ### attachment: 1 page: 7 post: 2 product: 1 shop_order: 2 shop_subscription: 8 ### Security ### Secure connection (HTTPS): ❌ Your store is not using HTTPS. Learn more about HTTPS and SSL Certificates. Hide errors from visitors: ❌Error messages should not be shown to visitors. ### Active Plugins (3) ### Code Snippets: by Code Snippets Pro – 3.4.0 WooCommerce Subscriptions: by WooCommerce – 5.1.3 WooCommerce: by Automattic – 7.8.0 (update to version 7.8.1 is available) ### Inactive Plugins (0) ### ### Settings ### API Enabled: – Force SSL: – Currency: USD ($) Currency Position: left Thousand Separator: , Decimal Separator: . Number of Decimals: 2 Taxonomies: Product Types: external (external) grouped (grouped) simple (simple) subscription (subscription) variable (variable) variable subscription (variable-subscription) Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog) exclude-from-search (exclude-from-search) featured (featured) outofstock (outofstock) rated-1 (rated-1) rated-2 (rated-2) rated-3 (rated-3) rated-4 (rated-4) rated-5 (rated-5) Connected to WooCommerce.com: – Enforce Approved Product Download Directories: ✔ HPOS feature screen enabled: – HPOS feature enabled: – Order datastore: WC_Order_Data_Store_CPT HPOS data sync enabled: – ### WC Pages ### Shop base: #6 - /shop/ Cart: #7 - /cart/ Checkout: #8 - /checkout/ My account: #9 - /my-account/ Terms and conditions: ❌ Page not set ### Theme ### Name: Twenty Twenty-One Version: 1.8 Author URL: https://wordpress.org/ Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme WooCommerce Support: ✔ ### Templates ### Overrides: – ### Subscriptions ### WCS_DEBUG: ✔ No Subscriptions Mode: ✔ Live Subscriptions Live URL: http://localhost:10028 Subscriptions-core Library Version: 5.7.2 Subscription Statuses: wc-active: 6 wc-on-hold: 1 wc-cancelled: 1 WooCommerce Account Connected: ❌ No Report Cache Enabled: ✔ Yes Cache Update Failures: ✔ 0 failure ### Store Setup ### Country / State: United States (US) — California ### Subscriptions by Payment Gateway ### ### Payment Gateway Support ### ### Admin ### Enabled Features: activity-panels analytics product-block-editor coupons customer-effort-score-tracks import-products-task experimental-fashion-sample-products shipping-smart-defaults shipping-setting-tour homescreen marketing mobile-app-banner navigation onboarding onboarding-tasks remote-inbox-notifications remote-free-extensions payment-gateway-suggestions shipping-label-banner subscriptions store-alerts transient-notices woo-mobile-welcome wc-pay-promotion wc-pay-welcome-page Disabled Features: core-profiler minified-js new-product-management-experience product-variation-management settings async-product-editor-category-field Daily Cron: ✔ Next scheduled: 2023-07-04 17:34:16 +00:00 Options: ✔ Notes: 70 Onboarding: skipped ### Action Scheduler ### Complete: 33 Oldest: 2023-06-20 17:35:16 +0000 Newest: 2023-07-03 19:51:45 +0000 Failed: 1 Oldest: 2023-06-20 17:35:16 +0000 Newest: 2023-06-20 17:35:16 +0000 Pending: 5 Oldest: 2023-07-03 19:53:24 +0000 Newest: 2023-07-17 19:38:24 +0000 ### Status report information ### Generated at: 2023-07-03 19:51:50 +00:00 ```