Added shipping_phone field to be copied in new order

Automattic / woocommerce-subscriptions-core

Subscriptions core package for WooCommerce

Other

88 stars 33 forks source link

Added shipping_phone field to be copied in new order #492

Closed rikovalkonen closed 1 year ago

rikovalkonen commented 1 year ago

Fixes # Fixed issue that prevent shipping_phone field copy to new order when subscription renews.

Description

How to test this PR

Create subscription and renew it then check if phone number is copied from parent/old order.

Product impact

[ ] Added changelog entry (or does not apply)
[X ] Will this PR affect WooCommerce Subscriptions? yes/no/tbc, add issue ref
[ ] Will this PR affect WooCommerce Payments? yes/no/tbc, add issue ref
[ ] Added deprecated functions, hooks or classes to the spreadsheet

james-allan commented 1 year ago

Hi there @rikovalkonen 👋

Thanks for the PR. Unfortunately this won't work on it's own because in newer versions of subscriptions we use a WC_Subscriptions_Data_Copier object to copy data from a subscription to renewal orders.

The function you have changed (wcs_copy_order_address()) is used only on checkout, not when renewal orders are created so I believe it needs to be fixed in both places.

I'm going to merge this PR because this change is correct but I'll submit another PR that fixes the issue in the WC_Subscriptions_Data_Copier.

Thanks again.

james-allan commented 1 year ago

PR that fixes the WC_Subscriptions_Data_Copier can be found here: https://github.com/Automattic/woocommerce-subscriptions-core/pull/493

Note that this PR doesn't have a changelog entry. The one I added in #493 covers the changes in this and that PR.