Fix subscription product sync options for yearly products not being editable

james-allan commented 3 months ago

Fixes https://github.com/woocommerce/woocommerce-subscriptions/issues/4588

Description

In https://github.com/Automattic/woocommerce-subscriptions-core/pull/508, the number input elements that enable store admin to select the day of the month for which yearly subscription products are synced to was changed from a <input type="number" ... > to a select2 (by giving it the wc-enhanced-select class. This essentially broke these elements because attempting to turn input elements into a select2 powered element didn't work - ie they had no options.

Screenshot 2024-03-09 at 10 43 12 am

This PR fixes this by turning these elements into true select2 elements via <select> and <option> elements.

Screenshot 2024-03-09 at 3 35 06 pm

How to test this PR

Simple Subscription.

Go to Products → Add new
Choose Simple subscription from the product type dropdown.
Enter a price and choose "yearly" as the subscription period.
In the "Synchronise renewals" section choose a month
Try to set a day.
On trunk you'll notice the dropdown is empty.
On this branch it should have all the days of the chosen month. eg
- 28 for February
- 30 for September
- 31 for January

Before	After

Confirm that saving the synchronisation product is correctly sets the product as a synced product to that date.
Confirm that unselecting a month option unsets the synchronisation property from the product.
Confirm that weekly, monthly products are unaffected by this change.

Variable Subscription

Go to Products → Add new
Choose Variable subscription from the product type dropdown.
Create variations
Enter a price and choose "yearly" as the subscription period.
In the "Synchronise renewals" section choose a month (eg January)
Try to set a day.
On trunk you'll notice the date selector is a number input.
On this branch it should be select2 with all the days of the chosen month as options. eg
- 28 for February
- 30 for September
- 31 for January

Before	After

Product impact

[x] Added changelog entry (or does not apply)
[ ] Will this PR affect WooCommerce Subscriptions? yes/no/tbc, add issue ref
[ ] Will this PR affect WooCommerce Payments? yes/no/tbc, add issue ref
[ ] Added deprecated functions, hooks or classes to the spreadsheet

james-allan commented 3 months ago

I didn't realise the fields I changed in this PR were that off. I guess everything else being out of line made that harder to see.

I've pushed a few commits that fix those alignment issues.

Simple Subscription

Screenshot 2024-03-18 at 4 26 25 pm
^{Weekly products only have 1 sync element} Screenshot 2024-03-18 at 4 27 05 pm ^{Yearly products only have 2 sync elements}