fix: label improvement on my subscription page - Githubissues

Automattic / woocommerce-subscriptions-core

Subscriptions core package for WooCommerce

Other

80 stars 29 forks source link

fix: label improvement on my subscription page #632

Closed frosso closed 2 weeks ago

frosso commented 2 weeks ago

Fixes https://github.com/woocommerce/woocommerce/issues/43627

Description

Similar changes to https://github.com/woocommerce/woocommerce/pull/48374 Adding an aria-label to the subscription link with the subscription number for screen readers.

How to test this PR

As a customer, place an order with a subscription item
As a customer, navigate to "My account > Subscriptions"
The links to the individual subscriptions should include an aria-label attribute

Product impact

[x] Added changelog entry (or does not apply)
[x] Will this PR affect WooCommerce Subscriptions? yes
[x] Will this PR affect WooCommerce Payments? no
[ ] Added deprecated functions, hooks or classes to the spreadsheet

frosso commented 2 weeks ago

@Automattic/quark if one of y'all could take a quick look, that'd be swell! ❤️

james-allan commented 2 weeks ago

Looks good to me. Thanks for the PR @frosso!