fix: label improvement on subscription and order pages - Githubissues

Automattic / woocommerce-subscriptions-core

Subscriptions core package for WooCommerce

Other

80 stars 29 forks source link

fix: label improvement on subscription and order pages #637

Closed frosso closed 4 days ago

frosso commented 4 days ago

Fixes https://github.com/woocommerce/woocommerce/issues/43627

Description

Similar changes to https://github.com/Automattic/woocommerce-subscriptions-core/pull/632 Adding an aria-label to the subscription & order links with the subscription/order number for screen readers.

How to test this PR

Related orders - merchant

As a customer, create a subscription
As a merchant, go to WooCommerce > Subscriptions
Select one of the subscriptions
Navigate to the "related orders" meta box
The aria-label attribute on the link should now be present

Before:

Screenshot 2024-06-26 at 12 44 52 PM

After:

Screenshot 2024-06-26 at 12 48 14 PM

Related orders - customer

As a customer, create a subscription
Go to My Account > Subscriptions
Select one of the subscriptions
Navigate to the "related orders" section of the page
The aria-label attribute on the link should now be present

Before:

Screenshot 2024-06-26 at 12 51 29 PM

After:

Screenshot 2024-06-26 at 12 52 45 PM

Related subscriptions

As a customer, create a subscription
Go to My Account > Orders
Select the order related to the subscription
Navigate to the "related subscriptions" section of the page
The aria-label attribute on the link should now be present

Before:

Screenshot 2024-06-26 at 12 54 13 PM

After:

Screenshot 2024-06-26 at 12 55 43 PM

Product impact

[x] Added changelog entry (or does not apply)
[x] Will this PR affect WooCommerce Subscriptions? yes
[x] Will this PR affect WooCommerce Payments? no
[ ] Added deprecated functions, hooks or classes to the spreadsheet

frosso commented 4 days ago

@Automattic/quark if one of y'all could take a quick look, that'd be swell! ❤️ thank you!