search

Automattic / wordpress-activitypub

ActivityPub for WordPress
https://wordpress.org/plugins/activitypub/
MIT License
484 stars 73 forks source link

Actor ID encoding #763

Open silverpill opened 4 months ago

silverpill commented 4 months ago

Quick summary

I found an actor that has Unicode characters in its ID: https://xn--y9aai3au2bc2f.xn--y9a3aq/գրառում/author/antranigv/ (nodeinfo). Looks like it is not a valid actor ID.

The ActivityPub specification says that identifiers must be "Publicly dereferencable URIs": https://www.w3.org/TR/activitypub/#obj-id But URIs can't contain Unicode characters, so I assume that these characters should be percent-encoded.

Steps to reproduce

curl -H "Accept: application/activity+json" https://xn--y9aai3au2bc2f.xn--y9a3aq/%D5%A3%D6%80%D5%A1%D5%BC%D5%B8%D6%82%D5%B4/author/antranigv/

What you expected to happen

Unicode characters should be percent-encoded.

What actually happened

ID contains Unicode characters

Impact

One

Available workarounds?

There is no user impact

Logs or notes

No response

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days.

silverpill commented 1 week ago

I don't think this has been fixed