search

Automattic / wp-api-console

WordPress (.com and .org) API Console written in React/Redux
GNU General Public License v2.0
70 stars 20 forks source link

Build: Transpile dependencies that otherwise break the build #89

Closed dmsnell closed 2 years ago

dmsnell commented 2 years ago

At some point the jsonpointer library started shipping code with ES2015+ syntax and const was breaking UglifyJS. This has resulted in an inability to build the project as described in the documention.

In this patch we're adding that module to our list of sources for babel to transpile, removing that syntax which UglifyJS doesn't understand.

cc: @youknowriad

dmsnell commented 2 years ago

cc: @sirreal @sgomes mind looking this over? I don't know anything about our deploy process for this and I'm willing to just go ahead and try to do it, but if you can spare a few cycles to look over the approach I'm taking I'd appreciate it.

Seems we are all dealing with dependencies deciding to ship the un-transpiled code and having to deal with that. I guess overall it's a win, but a pain in the process.

youknowriad commented 2 years ago

I'm willing to just give it a try as well, should we also go ahead and commit the package-lock as part of this?

sgomes commented 2 years ago

I don't see anything immediately wrong with this approach 👍

The process is indeed a pain, and will remain so until we have a good, standard way of distinguishing between different levels of language support. Which doesn't seem to be coming anytime soon.

dmsnell commented 2 years ago

should we also go ahead and commit the package-lock as part of this?

I wondered but decided to do that in a separate PR after it's working. I'll make a follow-up commit once this goes in and works just so we can avoid delaying development on this if we don't have to.