Replace "make run" with "npm start"

Automattic / wp-calypso-bootstrap

Development environment for Calypso - built with Vagrant and Puppet

GNU General Public License v2.0

33 stars 10 forks source link

Replace "make run" with "npm start" #12

Closed daveops1 closed 7 years ago

daveops1 commented 7 years ago

This is in reference to Issue (#14631) on the wp-calypso repository https://github.com/Automattic/wp-calypso/pull/14631/files removing makefile functionality. Updating bootstrap documentation to reflect this to run "npm start" instead of "make run" after the virtual machine is running.

stephanethomas commented 7 years ago

Thanks for your pull request @davidhortonweb!

I think we could also take advantage of it to update bash aliases as well:

https://github.com/Automattic/wp-calypso-bootstrap/blob/9971a2f1dbe794726008bd087966ab8b42222296/puppet/production/modules/bash/files/.bash_aliases#L7-L11

stephanethomas commented 7 years ago

@davidhortonweb: I've addressed my comment in https://github.com/Automattic/wp-calypso-bootstrap/commit/d9b118f7522c519998a8121317f1d75e09336e91 since I didn't get any reply from you. I'll merge your pull request now.