Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Food menus: empty state displays as load state #14413

Closed sarahmonster closed 3 years ago

sarahmonster commented 7 years ago

When opening the food menus tab, if there aren't any menu items, the empty state displayed is a load state. This makes it feel as though the page is loading indefinitely—I sat there for a while waiting until I realised it was actually finished.

food-menus-wtf

Compare to the empty state for testimonials, which feels right.

Steps to reproduce

  1. Activate any theme that uses the "food menus" CPT (Confit, Canape, etc) on a test site.
  2. Navigate to the "Food Menus" tab.
  3. Get confused.

What I expected

Expected to see an empty state more like what displays for testimonials:

screenshot 2017-05-24 13 24 06

What happened instead

A load state appears and never changes:

screenshot 2017-05-24 13 23 47
worldomonation commented 3 years ago

Hi! I'm performing triage on older bugs as part of Quality Squad's efforts to cut down on issue count.

Is this issue still applicable?

If not, I am proposing to close this issue with an appropriate label denoting reason for closure if no work is scoped for the near term.