Media Library: Flash of changing UI when closing.

[spen]

Summary

While working on #17150 we noticed that when closing the media picker modal from the detail view, we see a quick flash of the media-modal view/content changing before the modal while the modal is closing, as seen here:

This happens when closing the modal with the 'cancel' button, or when using the esc key.

Steps to reproduce

• Go to a blog post
• Select 'Featured Image' > 'Set Featured Image' from the side-bar
• Upload or select an image from your media library
• follow through to the image editor for that image
• Press esc or 'cancel' button

Notes

It seems we see this flash because of an update in state. We can see how the different views are rendered conditionally in this switch statement in /media-modal/index.jsx.

When we close the modal the onClose prop of the media-modal is called... media-modal/actions#resetMediaModalView is called too which looks to be what resets the view.

My gut tells me that delaying the reseting of this prop until after the modal has closed would do the trick (perhaps it needs a onClosed as well as a onClose callback, to handle such logic after the modal is done closing or something to that effect.

[worldomonation]

Hi! I'm performing triage on older bugs as part of Quality Squad's efforts to cut down on backlog issue counts.

As there has been no recent activity on this issue, the issue is being closed with the label Closed - Not Reproducible. If work is scoped and tabled for a milestone, please feel free to re-open this bug.