search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Remove or update the Gauge component #18134

Closed MichaelArestad closed 5 years ago

MichaelArestad commented 7 years ago

I was looking at the Gauge component for possible use and noticed a few things.

  1. It is not used anywhere I can find in Calypso.
  2. It's history is no longer available in this repo. Perhaps @apeatling or @aduth could help Sherlock its origin.
  3. It is blurry on hidpi screens because...
  4. It uses canvas.

It might be nice to use a gauge of some sort in our framework for a few things. I would prefer we be able to scrap it as is and use a new design without the use of canvas. If we aren't currently using it anywhere, I would like to take this approach.

If there is some reason it should stick around, it should be updated to look sharp on hidpi screens.

aduth commented 7 years ago

Appears it was originally added for stats, bounced around a bit, then inevitably removed from usage, leaving the component to remain. I think it would be safe (and preferable) to remove. @timmyc or @jancavan would be most familiar.

4463-gh-calypso-pre-oss 5889-gh-calypso-pre-oss 6414-gh-calypso-pre-oss

timmyc commented 7 years ago

It was used on the Insights page at one point - I think it would be fine to remove it.

jancavan commented 7 years ago

Yes, we can remove it.

stale[bot] commented 6 years ago

This issue has been marked as stale and will be closed in seven days. This happened because:

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

MichaelArestad commented 6 years ago

Still an issue. Just needs to be done.

stale[bot] commented 5 years ago

This issue has been marked as stale and will be closed in seven days. This happened because:

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.