Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Twitter Sharing Connection #25475

Closed aamills closed 6 years ago

aamills commented 6 years ago

Steps to reproduce

  1. Starting at URL: https://wordpress.com/sharing (select a site to test)
  2. Click blue "Connect" button next to Twitter.
  3. Error in pop up window is There was a problem connecting to Twitter to create an authorized connection. Please try again in a moment.
  4. Close pop up window and The Twitter connection could not be made because no account was selected. error appears in upper right with red exclamation point warning.

What I expected

I expected to be able add a twitter connection.

What happened instead

Two errors and no connection able to be established.

Browser / OS version

Chrome - Version 66.0.3359.181 (Official Build) (64-bit) Windows 10 Pro

Screenshot / Video

Screenshot of 1st error: image

Screenshot of 2nd error: image

Context / Source

user-report

Sidenote: Both the user and in our tests, are logged into Twitter in another tab/same browser session.

4303894-hc

arcangelinis commented 6 years ago

Also seeing the exact same issue from this AT site:

User: acebowers1 Site: https://acebowers.com/

The original issue was that their counts were not correct for the followers from Twitter. I suggested reconnecting. Disconnect had no errors, but when attempting to reconnect this error happened.

3646320-hc

designsimply commented 6 years ago

I tested using a WP.com Simple site with Firefox 60 and I was able to see the first error but not the second and my connection to Twitter worked despite the first error:

Video: 1m28s

there-was-a-problem-connecting-to-twitter Seen at https://wordpress.com/sharing/design5279.wordpress.com (production) using Firefox 60.0.1 on macOS 10.13.4.

I checked https://status.twitterstat.us/ because I thought an error like that might have been due to an outage and it said “Operational.” Still, this issue may be due to problems on Twitter's side so it may be helpful to note: are you seeing both errors?, are you able to connect despite the error(s)?, what part of the world are you testing from? I am located in Utah and tested a traceroute to twitter.com:

↪ traceroute -I twitter.com
traceroute: Warning: twitter.com has multiple addresses; using 104.244.42.1
traceroute to twitter.com (104.244.42.1), 64 hops max, 72 byte packets
 1  192.168.1.1 (192.168.1.1)  4.566 ms  1.787 ms  2.505 ms
 2  10.26.2.42 (10.26.2.42)  2.667 ms  2.865 ms  2.657 ms
 3  23-255-225-20.mci.googlefiber.net (23.255.225.20)  2.569 ms  3.403 ms  3.840 ms
 4  ae0.ar01.slc102.googlefiber.net (192.119.17.151)  2.653 ms  3.359 ms  3.865 ms
 5  * * *
 6  23-255-225-164.mci.googlefiber.net (23.255.225.164)  18.292 ms  17.864 ms  17.673 ms
 7  eqix2.cr2.sjc2.twttr.com (206.223.116.101)  22.276 ms  18.006 ms  18.379 ms
 8  * * *
 9  104.244.42.1 (104.244.42.1)  21.823 ms  21.382 ms  20.810 ms

from: IPv6 is: 2605:a601:3200:4d:3cfb:a259:b516:1d22 IPv4 is: 136.36.116.102

Aside: re-opened a related bug about overlapping account names during Sharing connection at https://github.com/Automattic/wp-calypso/issues/24045

designsimply commented 6 years ago

Note-worthy from @annezazu in an internal report (2364-gh-jpop-issues):

Of note, from the Twitter API account: https://twitter.com/TwitterAPI/status/1006635008692350977

As announced last month, today marks the beginning of callback URL whitelisting enforcement. Apps using Sign in with Twitter who have not whitelisted their URLs will experience disruption. To whitelist your URLs, follow the guidance in our May forum post. https://twittercommunity.com/t/action-required-sign-in-with-twitter-users-must-whitelist-callback-urls/105342

designsimply commented 6 years ago

Fixed by logging in as @wordpressdotcom to Twitter and and whitelisting https://public-api.wordpress.com/connect/. Props @justinshreve.

I tested and confirmed I could setup a new Twitter connection without error from a Simple, Simple with custom domain, and Jetpack site.

thesacredpath commented 6 years ago

Re-opening this as a new related issue has come up. If you try and use Twitter log in to comment on a .com site, or a self-hosted site with that feature active through Jetpack, the twitter login window content never loads.

Twitter announcement: https://twitter.com/Twitterrific/status/1006905620623167489

Steps to reproduce:

  1. on private window, make a comment on blog
  2. click to use Twitter log in
  3. new window opens but doesn't load

Twitter is working on this, but it would probably be good for us to find a workaround given we don't know how long it will take them to fix it.

thesacredpath commented 6 years ago

I've just checked again before closing this and opening an new issue and the above seems to have been fixed by Twitter as it is working for me now.