Open flootr opened 6 years ago
https://github.com/Automattic/wp-calypso/pull/45171 removes one of the store
consumers.
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.
Still relevant.
After looking at how lib/user
consumes and needs local storage, I think we'll end up needing store
more or less for some edge cases. We could refactor to use cookies of course, but I'm not sure it's a worthy improvement.
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.
Follow up on discussion in https://github.com/Automattic/wp-calypso/pull/26045
We use
store
in some places (see below) to persist data on client side storages (like localStorage) safely across browsers. However, we also uselocalforage
(wrapped in an async api). Both seem to serve the same use case.Let's iterate on whether we'd want to remove
store
in favor oflocalforage
. It seems the main difficulty lies instore
being used in a synchronous way while localforage is used in an asynchronous way.