Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

2FA Phone Validation: French Polynesia numbers failing validation #29943

Closed mikeyarce closed 4 years ago

mikeyarce commented 5 years ago

Steps to reproduce

  1. Starting at URL: https://wordpress.com/me/security/account-recovery
  2. Enter a valid French Polynesian phone number (89 XX XX XX)
  3. Validation fails

Related: https://github.com/Automattic/wp-calypso/issues/25163

In our forked version of node-phone, we only account for French Polynesia numbers having 6 digits, but they can also have 8! https://github.com/Automattic/node-phone/blob/e30f6b652a135819b5b9e7fa3bb84d36987a6cea/lib/iso3166Data.js#L1408-L1413

Reference: https://en.wikipedia.org/wiki/Telephone_numbers_in_French_Polynesia

I also tried entering a 6 digit phone but that seemed to fail as well, so not sure where the validation is failing.

rambogenius commented 5 years ago

For 9 digit numbers in Cameroon also the Validation fails. hc-11472712

katinthehatsite commented 5 years ago

I have another report from the Upworker in Cameroon who also can not secure their account:

Screen Shot 2019-05-08 at 1 12 21 PM

I tried a bunch of Cameroon phone numbers and none of them could validate.

stale[bot] commented 4 years ago

This issue has been marked as stale and will be closed in seven days. This happened because:

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.