Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Markdown Being Removed in Comments #31779

Closed synora closed 1 year ago

synora commented 5 years ago

User noticed that HTML Markdown in Comments are being removed after being saved in Calypso. This setting works as expected in wp-admin.

Steps to reproduce

  1. Starting at URL: https://wordpress.com/comment/andrealazzarotto.com/65263 and click edit
  2. Apply Unordered list and list item comments for the following two items:
    
    gli URL con msf.ticdn.it funzionano normalmente dalla mia connessione italiana, mentre effettivamente risultano irrisolvibili (proprio già dal DNS) quando mi collego dall’estero (ho provato Svezia e Francia)

gli URL con msf.cdn.mediaset.net funzionano sia dall’Italia che dall’estero


3. Save 

#### What I expected
This: https://cld.wthms.co/Jtwaz8

#### What happened instead
The markdown that was just added and save will be removed. This only occurs within Calypso. The markdown is saved it edited within the comments section of wp-admin.

#### Browser / OS version
 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:65.0) Gecko/20100101 Firefox/65.0

#### Screenshot / Video
https://www.youtube.com/watch?v=MeaDUhHBSSQ&feature=youtu.be

#### Context / Source
Chat: 70563-hc
Follow Up Ticket: 1910665-zen

<!--
PLEASE NOTE
- These comments won't show up when you submit the issue.
- Everything is optional, but try to add as many details as possible.

Docs & troubleshooting:
https://github.com/Automattic/wp-calypso/blob/master/.github/CONTRIBUTING.md
https://github.com/Automattic/wp-calypso/blob/master/docs/troubleshooting.md

Helpful tips for screenshots:
https://en.support.wordpress.com/make-a-screenshot/
-->
stale[bot] commented 4 years ago

This issue has been marked as stale and will be closed in seven days. This happened because:

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

Lazza commented 4 years ago

It has been inactive in the past 9 months

Is this a joke?

stale[bot] commented 4 years ago

This issue has been marked as stale and will be closed in seven days. This happened because:

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

Lazza commented 4 years ago

Again, is this a joke? We are paying for the product and the bug has not been addressed or even commented at all for over one year?

github-actions[bot] commented 3 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Lazza commented 3 years ago

What the heck! Seriously?

synora commented 3 years ago

@gwwar Can we get an update on this? See also: https://github.com/Automattic/wp-calypso/issues/21246

gwwar commented 3 years ago

@obenland @simison would y'all like to help triage this one

obenland commented 3 years ago

Pointing Comments back to wp-admin might be most expedient way to avoid running into this

Lazza commented 3 years ago

I respectfully disagree: end users cannot use wp-admin to leave comments on WP blogs.

obenland commented 3 years ago

This issue seems to be specific to editing existing comments from within Calypso. Is that not the case?

Lazza commented 3 years ago

The issue is not specific to Markdown, the tags get stripped after they are converted to HTML.

They get stripped on the front end as well, see for instance #21246.

To be fair I don't know if the cause is the same, but the final result is the same. Stripped tags while they should be preserved.

CoachBirgit commented 3 years ago

User turns received customer feedback manually as site admin into comments to a dedicated page. They would like to edit the comments in a later step and add images by adding them with the Markdown options as HTML tagimg to the comment text.

They demonstrate the process with a video. They use the WP.com view (Calypso). After saving the comment with valid HTML for the image, the HTML gets stripped of the content.

I could reproduce this on one of my test sites. Editing in WP-Admin works, but if I open and save without changes the same comment afterwards in Calypso, the HTML gets stripped out again.

Context: zen-4346993

/cc @obenland

github-actions[bot] commented 2 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Lazza commented 2 years ago

Please do not close this, thank you.

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.

zachspears commented 1 year ago

Hello @synora and @Lazza, I am having trouble duplicating this issue for testing and prioritizing. andrealazzarotto.com is no longer hosted with WordPress.com so I am unable to follow the original troubleshooting steps. Additionally, I have tried adding my own comments with markdown to a test site in order to test but was unable to successfully recreate the outlined issue.

Please provide updated troubleshooting steps, preferably that can be recreated in a test site so that we can move this bug report along. Thank you!

Lazza commented 1 year ago

About a year ago I abandoned WP.com, despite having been a paying customer for several years (and a free user before).

This issue, among other bugs I reported or discussed with support, unfortunately shows that there was (is?) zero interest in fixing stuff.

Fun fact: for two consecutive years, support granted me a free custom CSS upgrade rather than fixing a CSS bug for a theme I was using. The fix required two lines of CSS and I had provided them when asking for help.

As you mentioned, my website is not hosted there anymore. It was not feasible to stay on WP.com also for legal reasons, e.g. the impossibility of respecting GDPR while using your SaaS. Hence I will not be able to provide updated troubleshooting steps.

For years I tried to help fixing things (also for other WP.com users) by keeping the issues open and preventing them for becoming stale, given that they were still present. Now it's time to go on with life.

I hope you will understand and, if any of the bugs I reported ever get solved, thank you in advance for the fix!

cometgrrl commented 1 year ago

This issue has been resolved/does not reproduce anymore.